packages/ui-solid/src/auto-imports.d.ts (1)

9-92: Generated icon globals: formatting-only churn; identifiers unchanged

The set of global icon identifiers and their default-type accessors remain identical; only quotes/semicolons/spacing changed. No semantic impact.

If feasible, align the unplugin-auto-import generator’s quote/semicolon settings to reduce diffs in future runs.

apps/desktop/src/utils/tauri.ts (3)

8-10: Nit: redundant return await in async functions

In cases without a surrounding try/catch, return TAURI_INVOKE(...) is equivalent and avoids an extra await. Not critical, especially in generated code.

If you ever adjust the generator, consider this pattern:

-async setMicInput(label: string | null) : Promise<null> {
-    return await TAURI_INVOKE("set_mic_input", { label });
-},
+async setMicInput(label: string | null) : Promise<null> {
+    return TAURI_INVOKE("set_mic_input", { label });
+},

---

447-451: Importing Channel as a value is unnecessary here; prefer type-only import

Channel is only used in type position (TAURI_CHANNEL<FramesRendered>). Since invoke already brings in the module as a value, this is minor, but you can avoid extra value imports.

Apply if/when adjusting the generator:

 import {
 	invoke as TAURI_INVOKE,
-	Channel as TAURI_CHANNEL,
+	type Channel as TAURI_CHANNEL,
 } from "@tauri-apps/api/core";

---

328-330: Heads-up: duplicate Bounds type name in codebase

This file exports Bounds = { x, y, width, height }, while apps/desktop/src/utils/box.ts has Bounds = { size: XY; position: XY } (different shape). Not new, but it’s easy to import the wrong one by name.

Consider:

• Aliasing on import at call sites (e.g., import type { Bounds as TauriBounds } ...) to avoid confusion, or
• Renaming one of the types at the source (if feasible via generator settings) to make intent explicit (e.g., WindowBounds vs LogicalBounds).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

apps/desktop/src/routes/editor/ConfigSidebar.tsx (3)

653-663: Simplify handleBackgroundTabChange (all cases do the same).

Since all four cases invoke ensurePaddingForBackground(), you can collapse the switch and future-proof it against new background types.

Apply:

-// this will run when user select a background tab
-const handleBackgroundTabChange = (tab: BackgroundSource["type"]) => {
-  switch (tab) {
-    case "image":
-    case "color":
-    case "gradient":
-    case "wallpaper":
-      ensurePaddingForBackground();
-      break;
-  }
-};
+// this will run when user selects a background tab
+const handleBackgroundTabChange = (_tab: BackgroundSource["type"]) => {
+  ensurePaddingForBackground();
+};

---

1041-1042: Avoid a second history entry when selecting wallpapers; make it atomic.

Calling ensurePaddingForBackground() outside debouncedSetProject can create two separate history entries (padding change and wallpaper change). Move the ensure call inside debouncedSetProject’s batched update so the user gets a single undo step.

Apply this removal here:

-  ensurePaddingForBackground();

And update debouncedSetProject (outside this hunk) like this:

// Replace the existing debouncedSetProject with this version
const debouncedSetProject = (wallpaperPath: string) => {
  const resumeHistory = projectHistory.pause();
  queueMicrotask(() => {
    batch(() => {
      setProject("background", "source", {
        type: "wallpaper",
        path: wallpaperPath,
      } as const);
      ensurePaddingForBackground();
      resumeHistory();
    });
  });
};

---

1148-1192: Image upload flow doesn’t currently trigger padding default; add ensure there.

If the project is already on the “image” tab (no tab change), selecting/uploading an image won’t run handleBackgroundTabChange, so padding may remain 0 (contrary to the PR intent of applying to uploaded images). Call ensurePaddingForBackground() after setting the image source.

Add the call after setProject:

setProject("background", "source", {
  type: "image",
  path: fullPath,
});
ensurePaddingForBackground();

Note: If you also move ensurePaddingForBackground() into debouncedSetProject (as suggested for wallpapers), that won’t affect this code path; you still need the ensure call here.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

apps/desktop/src/routes/editor/ConfigSidebar.tsx (5)

645-650: Auto-padding helper is good; centralize the default and guard non-positive values.

This looks correct and idempotent. Two small improvements:

• Replace the magic number 10 with a file-level constant to keep a single source of truth.
• Guard against any non-positive values (<= 0) to be future-proof.

Apply this diff:

-	// set padding if background is selected
-	const ensurePaddingForBackground = () => {
-		if (project.background.padding === 0)
-			setProject("background", "padding", 10);
-	};
+	// Auto-apply a default padding when a background is selected and padding is zero
+	const DEFAULT_BACKGROUND_PADDING = 10;
+	const ensurePaddingForBackground = () => {
+		if (project.background.padding <= 0) {
+			setProject("background", "padding", DEFAULT_BACKGROUND_PADDING);
+		}
+	};

Follow-up note: If you want this applied universally whenever a wallpaper/image is chosen (even without switching tabs), wire this helper into those onChange handlers too (see comments below).

---

792-844: Batch ensurePadding + source-type switch to produce a single history entry (and avoid extra renders).

Calling ensurePaddingForBackground outside the switch works, but it will create a separate update from the source-type change. Wrap both in Solid’s batch so they coalesce into one update/history entry.

Apply this diff:

 					onChange={(v) => {
 						const tab = v as BackgroundSource["type"];
-						ensurePaddingForBackground();
-						switch (tab) {
+						batch(() => {
+							ensurePaddingForBackground();
+							switch (tab) {
 							case "image": {
 								setProject("background", "source", {
 									type: "image",
 									path:
 										project.background.source.type === "image"
 											? project.background.source.path
 											: null,
 								});
 								break;
 							}
 							case "color": {
 								setProject("background", "source", {
 									type: "color",
 									value:
 										project.background.source.type === "color"
 											? project.background.source.value
 											: DEFAULT_GRADIENT_FROM,
 								});
 								break;
 							}
 							case "gradient": {
 								setProject("background", "source", {
 									type: "gradient",
 									from:
 										project.background.source.type === "gradient"
 											? project.background.source.from
 											: DEFAULT_GRADIENT_FROM,
 									to:
 										project.background.source.type === "gradient"
 											? project.background.source.to
 											: DEFAULT_GRADIENT_TO,
 									angle:
 										project.background.source.type === "gradient"
 											? project.background.source.angle
 											: 90,
 								});
 								break;
 							}
 							case "wallpaper": {
 								setProject("background", "source", {
 									type: "wallpaper",
 									path:
 										project.background.source.type === "wallpaper"
 											? project.background.source.path
 											: null,
 								});
 								break;
 							}
-						}
+							}
+						});
 					}}

Optional: You may want to skip auto-padding when switching to the Image tab and there is no image selected yet (path is null). If that’s desired, gate ensurePaddingForBackground() behind something like: tab !== "image" || (project.background.source.type === "image" && project.background.source.path). I can draft that if you prefer.

---

1161-1179: Upload image path should also trigger auto-padding (same rationale as wallpapers).

If the user is already on the Image tab (with padding 0) and uploads a file, we currently don’t auto-apply padding. Call ensurePaddingForBackground() (or batch it) right after setting the image path so uploaded images are covered too.

Proposed change (outside the changed hunk), inside the try block after setProject for the image:

setProject("background", "source", {
  type: "image",
  path: fullPath,
});
ensurePaddingForBackground(); // or batch together with the setProject call

Alternatively, adopt the same batching pattern as with wallpapers:

batch(() => {
  setProject("background", "source", { type: "image", path: fullPath });
  if (project.background.padding <= 0) {
    setProject("background", "padding", DEFAULT_BACKGROUND_PADDING);
  }
});

---

653-691: onMount wallpaper migration path doesn’t apply auto-padding.

When a persisted wallpaper ID is resolved to a file URL on mount (radioGroupOnChange path), padding isn’t enforced. If you move the auto-padding into debouncedSetProject (as suggested), this path will automatically benefit. Otherwise, add ensurePaddingForBackground() in that flow too.

---

1018-1032: Wallpaper selection: batch auto-padding with the source update in debouncedSetProject

To avoid a separate history entry—or worse, losing the padding change if history is paused—let’s move ensurePaddingForBackground() inside the same microtask batch where we set the wallpaper. That way both padding and the new source land in one atomic update.

• In apps/desktop/src/routes/editor/ConfigSidebar.tsx around line 1026, remove the standalone call to ensurePaddingForBackground() in the photo‐URL onChange handler:

-    debouncedSetProject(wallpaper.rawPath);
-    ensurePaddingForBackground();
+    debouncedSetProject(wallpaper.rawPath);

• In the debouncedSetProject definition (around line 744), prepend the padding check before setting the source:

const debouncedSetProject = (wallpaperPath: string) => {
  const resumeHistory = projectHistory.pause();
  queueMicrotask(() => {
    batch(() => {
+     if (project.background.padding <= 0) {
+       setProject("background", "padding", DEFAULT_BACKGROUND_PADDING);
+     }
      setProject("background", "source", {
        type: "wallpaper",
        path: wallpaperPath,
      } as const);
      resumeHistory();
    });
  });
};

This ensures the padding and wallpaper-path updates are recorded together.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.